aboutsummaryrefslogtreecommitdiff
path: root/.github/workflows/on_pull_request.yaml
diff options
context:
space:
mode:
authorAarni Koskela <akx@iki.fi>2023-05-17 13:31:01 +0300
committerAarni Koskela <akx@iki.fi>2023-05-17 16:09:06 +0300
commit4f11f285f912fd48bc85a650a0384b6044d68b86 (patch)
treeee3ca6f3c40a79958692857802618943503243f7 /.github/workflows/on_pull_request.yaml
parent13f4c62ba3870f172e6fdb26d4f33576f7f60f7e (diff)
Add ESLint to CI
Diffstat (limited to '.github/workflows/on_pull_request.yaml')
-rw-r--r--.github/workflows/on_pull_request.yaml36
1 files changed, 12 insertions, 24 deletions
diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml
index d42965b1..7b7219fd 100644
--- a/.github/workflows/on_pull_request.yaml
+++ b/.github/workflows/on_pull_request.yaml
@@ -1,19 +1,11 @@
-# See https://github.com/actions/starter-workflows/blob/1067f16ad8a1eac328834e4b0ae24f7d206f810d/ci/pylint.yml for original reference file
name: Run Linting/Formatting on Pull Requests
on:
- push
- pull_request
- # See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpull_requestpull_request_targetbranchesbranches-ignore for syntax docs
- # if you want to filter out branches, delete the `- pull_request` and uncomment these lines :
- # pull_request:
- # branches:
- # - master
- # branches-ignore:
- # - development
jobs:
- lint:
+ lint-python:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
@@ -29,18 +21,14 @@ jobs:
run: pip install ruff==0.0.265
- name: Run Ruff
run: ruff .
-
-# The rest are currently disabled pending fixing of e.g. installing the torch dependency.
-
-# - name: Install PyLint
-# run: |
-# python -m pip install --upgrade pip
-# pip install pylint
-# # This lets PyLint check to see if it can resolve imports
-# - name: Install dependencies
-# run: |
-# export COMMANDLINE_ARGS="--skip-torch-cuda-test --exit"
-# python launch.py
-# - name: Analysing the code with pylint
-# run: |
-# pylint $(git ls-files '*.py')
+ lint-js:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Code
+ uses: actions/checkout@v3
+ - name: Install Node.js
+ uses: actions/setup-node@v3
+ with:
+ node-version: 18
+ - run: npm i --ci
+ - run: npm run lint